Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAPRINDASHVILI] Scope ui and api server searches to recently active servers #17978

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 12, 2018

Scope ui and api server searches to recently active servers

(cherry picked from commit ebfcf7c)
https://bugzilla.redhat.com/show_bug.cgi?id=1607409

@miq-bot miq-bot changed the title Merge pull request #17670 from bdunne/only_contact_active_ws_servers [GAPRINDASHVILI] Merge pull request #17670 from bdunne/only_contact_active_ws_servers Sep 12, 2018
@simaishi simaishi changed the title [GAPRINDASHVILI] Merge pull request #17670 from bdunne/only_contact_active_ws_servers [GAPRINDASHVILI] Scope ui and api server searches to recently active servers Sep 17, 2018
@simaishi simaishi requested a review from gtanzillo September 17, 2018 19:25
@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2018

This pull request is not mergeable. Please rebase and repush.

…servers

Scope ui and api server searches to recently active servers

(cherry picked from commit ebfcf7c)
https://bugzilla.redhat.com/show_bug.cgi?id=1607409
@miq-bot
Copy link
Member

miq-bot commented Sep 27, 2018

Checked commits bdunne/manageiq@cdebf34~...1940c05 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@bdunne
Copy link
Member Author

bdunne commented Sep 27, 2018

@gtanzillo Can you review when you have a couple minutes?

@bdunne bdunne removed the unmergeable label Oct 1, 2018
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simaishi simaishi merged commit 86878f3 into ManageIQ:gaprindashvili Oct 2, 2018
@simaishi simaishi added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
@bdunne bdunne deleted the gap_17670 branch October 2, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants